Skip to content

Add AI acknowledgement checkbox and welcome comment #2624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RDaxini wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add AI acknowledgement checkbox and welcome comment #2624

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
eb0f127
Update PULL_REQUEST_TEMPLATE.md
RDaxini Dec 16, 2025
6554dfb
shorten pr checkbox
RDaxini Dec 16, 2025
490942c
add welcome for pr and issue
RDaxini Dec 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/PULL_REQUEST_TEMPLATE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

- [ ] Closes #xxxx
- [ ] I am familiar with the [contributing guidelines](https://pvlib-python.readthedocs.io/en/latest/contributing/index.html)
- [ ] Any AI-generated material has been vetted for accuracy and compatability with the pvlib contributing guidelines
- [ ] Tests added
- [ ] Updates entries in [`docs/sphinx/source/reference`](https://github.com/pvlib/pvlib-python/blob/main/docs/sphinx/source/reference) for API changes.
- [ ] Adds description and name entries in the appropriate "what's new" file in [`docs/sphinx/source/whatsnew`](https://github.com/pvlib/pvlib-python/tree/main/docs/sphinx/source/whatsnew) for all changes. Includes link to the GitHub Issue with `` :issue:`num` `` or this Pull Request with `` :pull:`num` ``. Includes contributor name and/or GitHub username (link with `` :ghuser:`user` ``).
Expand Down
33 changes: 33 additions & 0 deletions .github/workflows/welcome.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
name: Welcome First-Time Contributor

on:
issues:
types: opened
pull_request_target:
types: opened

permissions: {}
Copy link
Contributor

@echedey-ls echedey-ls Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not needed, probably.

Suggested change
permissions: {}


jobs:
welcome:
runs-on: ubuntu-latest
permissions:
issues: write
pull-requests: write
steps:
- uses: plbstl/first-contribution@v4
with:
issue-opened-msg: |
### Hey @{fc-author}! :wave:

Thanks for opening your first issue. Welcome to the community!
Comment on lines +20 to +23
Copy link
Contributor

@echedey-ls echedey-ls Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really want this? IMO, it's not adding any value to the conversation. Plus, an automated thanks/welcome is less welcoming than anybody of us writing a "Confirmed. Thanks for noticing that @ ...!!" message. More natural.

Copy link
Member Author

@RDaxini RDaxini Dec 16, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really want this? IMO, it's not adding any value to the conversation. Plus, an automated thanks/welcome is less welcoming than anybody of us writing a "Confirmed. Thanks for noticing that @ ...!!" message. More natural.

I was debating that in my head and then just included it in the end, but I agree with you—a personal welcome from us would be better.

pr-opened-msg: |
### Hey @{fc-author}! :tada:

Thanks for opening your first pull request! We appreciate your
contribution. Please ensure you have reviewed and understood the
[contributing guidelines](https://pvlib-python.readthedocs.io/en/latest/contributing/index.html).

If AI is used for any portion of this PR, you must vet the content
for technical accuracy and compatibility with the contributing
guidelines.
Copy link
Contributor

@echedey-ls echedey-ls Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
guidelines.
guidelines.

Missing newline at the end (consistency and Git tradition)