Increase test coverage for simple_efficiency and clarify loss parameter docs #2658
+43
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docs/sphinx/source/referencefor API changes.This PR increases test coverage for
pvlib.transformer.simple_efficiencybyadding tests that explicitly exercise NumPy array inputs, including the edge
case where
load_loss = 0. The tests document the current behavior whenload_lossis zero without changing the implementation.In addition, the docstring parameter types for
load_lossandno_load_lossare updated from
numerictofloatto better reflect their intended usage,as discussed in the linked issue.