Skip to content

Conversation

@kumaradityaapril
Copy link

@kumaradityaapril kumaradityaapril commented Jan 20, 2026

  • Closes Add simple_efficiency tests to cover numpy arrays and pandas Series #2649
  • I am familiar with the contributing guidelines
  • Tests added
  • Updates entries in docs/sphinx/source/reference for API changes.
  • Adds description and name entries in the appropriate "what's new" file.
  • New code is fully documented.
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels and Milestone are assigned.

This PR increases test coverage for pvlib.transformer.simple_efficiency by
adding tests that explicitly exercise NumPy array inputs, including the edge
case where load_loss = 0. The tests document the current behavior when
load_loss is zero without changing the implementation.

In addition, the docstring parameter types for load_loss and no_load_loss
are updated from numeric to float to better reflect their intended usage,
as discussed in the linked issue.

@cwhanse
Copy link
Member

cwhanse commented Jan 20, 2026

@kumaradityaapril this PR needs to wait on #2646 which addresses the division by zero error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add simple_efficiency tests to cover numpy arrays and pandas Series

2 participants