9 scanning screen with startstop and results #18

lilstiffy · 2025-09-15T17:06:47Z

This pull request introduces the live feed feature for scan events, allowing users to view real-time scan progress and warnings in the UI. The changes include backend support for fetching live feed data, new exception handling, UI updates to display the live feed, and utility methods for formatting and counting warnings. The polling logic is updated to fetch live feed updates periodically and handle scan completion scenarios.

Backend and API changes:

Added the LiveFeedException class to handle errors specific to live feed retrieval.
Introduced the LIVE_FEED endpoint in the Endpoint enum and implemented the getLiveFeed method in ScanService, which fetches live feed updates and handles various error scenarios. [1] [2]
Added the LiveFeedResponse record to encapsulate scan running status and live feed data.

UI and presenter logic:

Updated HomePresenter to poll live feed updates during scans, display live feed and diff count in the UI, and handle scan completion with user prompts for viewing details. [1] [2] [3] [4]
Expanded the scan tab layout in HomeScreen.form to accommodate new live feed components.

Utilities and user interaction:

Added LiveFeedUtils with methods for formatting live feed entries and counting warnings, improving readability and diff tracking.
Implemented a generic showOptionDialog method in BaseScreen for user prompts, used when a scan completes with differences.

NOTE: MARKED AS DRAFT

Discussion is needed for the comment i put in HomePresenter l:216-219

Copilot

Pull Request Overview

This pull request introduces a comprehensive live feed feature for scan events, enabling users to monitor real-time scan progress and view warnings in the UI. The implementation includes backend API support, new exception handling, UI updates with live feed components, and enhanced user interaction patterns.

Added live feed API endpoint and service methods with proper error handling
Updated UI layout to accommodate live feed display with scan progress and diff counting
Implemented polling mechanism for real-time updates and scan completion handling with user prompts

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
HomeScreen.java	Updated UI layout removing old scan button and adding live feed components
HomeScreen.form	Modified form layout to expand scan tab grid and add live feed UI elements
BaseScreen.java	Added generic option dialog method for user interaction prompts
LiveFeedUtils.java	New utility class for formatting live feed entries and counting warnings
ScanDetailsPresenter.java	Fixed potential null pointer exception with list initialization
HomePresenter.java	Major refactoring to implement live feed polling and scan completion handling
LiveFeedResponse.java	New record for encapsulating live feed API response data
Endpoint.java	Added LIVE_FEED endpoint constant
ScanService.java	Implemented getLiveFeed method with proper error handling
LiveFeedException.java	New exception class for live feed specific errors

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

src/main/java/org/pwss/view/screen/HomeScreen.java

src/main/java/org/pwss/presenter/HomePresenter.java

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copilot

Pull Request Overview

Copilot reviewed 23 out of 23 changed files in this pull request and generated 3 comments.

Comments suppressed due to low confidence (1)

src/main/java/org/pwss/view/screen/ScanDetailsScreen.java:1

The variable name rootpanel on line 19 should be renamed to follow camelCase convention like the other fields. It should be rootPanel to match the existing field.

package org.pwss.view.screen;

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

src/main/java/org/pwss/view/screen/BaseScreen.java

src/main/java/org/pwss/presenter/HomePresenter.java

lilstiffy · 2025-09-17T11:25:56Z

@pwgit-create Finished the last small details during my lunch break :)
Have a look when you have time 💯
I'll have band practise after my work day so talk to you later this evening 🎸🥁

pwgit-create

Det är en ren fröjd att se vilket bra resultat ni fått av Frontend appen genom era presentationer samt koden här. Vilket arbete ni har lagt ner kamrat , imponerade! 😃

Vill att koden ska bli så bra som möjligt (när ni lagt ner så mycket arbete på denna PR) så var därför jag bad om ändringar.
Det är i princip bara att följa alla Github Copilots instruktioner (har markerat visssa med Agree). De är bra , har verifierat ändringarna Copilot ville se - de kommer gå snabbt att implementera!

Utöver Copilots förslag har jag också lagt ett en egen ändring som jag ville se. Den går också relativt fort att implementera. Gör resolve på alla review comments när ni är färdiga med dem.

Med detta sagt , 100 på arbetet här kamrat! Var stolt över dig själv - nu börjar File-Integrity-Scanner faktiskt bli någonting 💫

src/main/java/org/pwss/model/table/DiffTableModel.java

src/main/java/org/pwss/navigation/Screen.java

src/main/java/org/pwss/presenter/HomePresenter.java

src/main/java/org/pwss/view/screen/BaseScreen.java

src/main/java/org/pwss/view/screen/HomeScreen.form

pwgit-create · 2025-09-18T18:59:13Z

src/main/java/org/pwss/model/table/DiffTableModel.java

+     *         or an empty Optional if the index is out of bounds.
     */
-    public Diff getDiffAt(int rowIndex) {
+    public Optional<Diff> getDiffAt(int rowIndex) {


Bra @lilstiffy !

pwgit-create · 2025-09-18T19:00:10Z

src/main/java/org/pwss/presenter/HomePresenter.java

-                    MonitoredDirectory dir = model.getDirectoryAt(modelRow);
-                    startScanSuccess = scanService.startScanById(dir.id());
+                    Optional<MonitoredDirectory> dir = model.getDirectoryAt(modelRow);
+                    if (dir.isPresent()) {


pwgit-create · 2025-09-18T19:16:47Z

src/main/java/org/pwss/utils/StringConstants.java

+/**
+ * A utility class that holds various string constants used throughout the application.
+ */
+public final class StringConstants {


Bättre än innan även om jag föredrar att String konstanter som bara används i en klass också placeras i samma klass. Är en smaksak så kommer inte påverka PR. Vill ni inte ha konstanterna i minnet så kan ni använda en XML fil och Parsa String värdet när ni behöver det. Det är lite trixat att implementera sådana lösningar eftersom ni måste:

Läsa värdet från en XML fil (Läsa bytes från en stream mao) och göra om det till en Sträng.

För att vinna något på den strategin får ni inte spara Strängen i en persistent variabel. Detta innebär att ni får läsa strängen från fil på nytt varje gång den används. Det kommer ta tid.

IT-säkerhet. Kommer behövas att tänka på input sanitation!

Det finns nog mer effektiva sätt att hantera strängar från filer, så ni kan gärna undersöka det om ni vill. Jag tycker dock att det sätt ni har gjort på är tillräckligt bra, och det bästa är nog att ni fokuserar på att få ut första versionen av releasen. Efter det kan ni titta på att förbättra lagringen av strängarna om ni vill. Men gör som ni vill, det är bara mitt tips 😊

Är ni intresserad kolla här: https://www.baeldung.com/java-parse-xml-string

@lilstiffy

Valid! Vi kanske kan skapa en puck på att ha strängarna i XML istället! :)

pwgit-create · 2025-09-18T19:17:48Z

src/main/java/org/pwss/presenter/HomePresenter.java

            SwingUtilities.invokeLater(() -> {
                if (stopScanSuccess) {
-                    screen.showSuccess("Scan stopped successfully!");
+                    screen.showSuccess(StringConstants.SCAN_STOPPED_SUCCESS);


pwgit-create · 2025-09-18T19:18:07Z

src/main/java/org/pwss/model/table/ScanTableModel.java

+            return Optional.of(scans.get(rowIndex));
        }
-        return null;
+        return Optional.empty();


pwgit-create · 2025-09-18T19:18:56Z

src/main/java/org/pwss/utils/StringConstants.java

 package org.pwss.utils;

+/**
+ * A utility class that holds various string constants used throughout the application.


Java Docs 💯 +

We like it!
Java docs is 🔥

pwgit-create

🎉 Ni har verkligen fixat allt på ett toppenbra sätt! 🙌 Nu kan ni merga in koden från en riktigt välgjord PR till er Develop Branch. 💻✨ Fantastiskt jobbat, Stefan! 😄

lilstiffy · 2025-09-18T20:32:26Z

🎉 Ni har verkligen fixat allt på ett toppenbra sätt! 🙌 Nu kan ni merga in koden från en riktigt välgjord PR till er Develop Branch. 💻✨ Fantastiskt jobbat, Stefan! 😄

Tack så jättemycket kamrat! 🫡 🥇

lilstiffy added 5 commits September 10, 2025 20:37

Initial progress!

bb729cf

Merge develop

4b6364a

Diff count progress

c103f14

Fix count not updating in UI and added new option dialog in base screen

b6c37a3

Added extra else if case in onFinishScan plus discussion comment

785cbfc

lilstiffy requested review from Copilot and pwgit-create September 15, 2025 17:06

lilstiffy self-assigned this Sep 15, 2025

Copilot AI reviewed Sep 15, 2025

View reviewed changes

src/main/java/org/pwss/view/screen/HomeScreen.java Outdated Show resolved Hide resolved

src/main/java/org/pwss/presenter/HomePresenter.java Outdated Show resolved Hide resolved

src/main/java/org/pwss/presenter/HomePresenter.java Outdated Show resolved Hide resolved

lilstiffy added 3 commits September 15, 2025 19:10

Fix indentations

4b53f12

Make LiveFeedUtils final

1d689d4

Minor improvements

c16282a

lilstiffy requested a review from Copilot September 15, 2025 18:13

Copilot AI reviewed Sep 15, 2025

View reviewed changes

lilstiffy added 3 commits September 16, 2025 21:59

Some summary showing and diffs showing, still more work needed :)

84d4ba3

Result view and navigation events when completed scans with diffs

7c308dc

Merge develop

36c3b37

lilstiffy marked this pull request as ready for review September 17, 2025 11:24

lilstiffy requested a review from Copilot September 17, 2025 11:24

Copilot AI reviewed Sep 17, 2025

View reviewed changes

src/main/java/org/pwss/view/screen/BaseScreen.java Outdated Show resolved Hide resolved

src/main/java/org/pwss/presenter/HomePresenter.java Outdated Show resolved Hide resolved

src/main/java/org/pwss/presenter/HomePresenter.java Outdated Show resolved Hide resolved

lilstiffy linked an issue Sep 17, 2025 that may be closed by this pull request

Scanning screen with Start/Stop and Results #9

Closed

4 tasks

pwgit-create requested changes Sep 17, 2025

View reviewed changes

lilstiffy added 2 commits September 18, 2025 18:38

Resolve comments from pwgit-create and our friend Copilot :)

d352519

Added small doc to StringConstants class

e0d19d2

lilstiffy requested a review from pwgit-create September 18, 2025 16:41

pwgit-create reviewed Sep 18, 2025

View reviewed changes

pwgit-create approved these changes Sep 18, 2025

View reviewed changes

lilstiffy merged commit 420d839 into develop Sep 18, 2025
2 checks passed

9 scanning screen with startstop and results #18

9 scanning screen with startstop and results #18

Uh oh!

Conversation

lilstiffy commented Sep 15, 2025

NOTE: MARKED AS DRAFT

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lilstiffy commented Sep 17, 2025

Uh oh!

pwgit-create left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pwgit-create Sep 18, 2025

Choose a reason for hiding this comment

Uh oh!

pwgit-create Sep 18, 2025

Choose a reason for hiding this comment

Uh oh!

pwgit-create Sep 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lilstiffy Sep 18, 2025

Choose a reason for hiding this comment

Uh oh!

pwgit-create Sep 18, 2025

Choose a reason for hiding this comment

Uh oh!

pwgit-create Sep 18, 2025

Choose a reason for hiding this comment

Uh oh!

pwgit-create Sep 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lilstiffy Sep 18, 2025

Choose a reason for hiding this comment

Uh oh!

pwgit-create left a comment

Choose a reason for hiding this comment

Uh oh!

lilstiffy commented Sep 18, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

pwgit-create Sep 18, 2025 •

edited

Loading

pwgit-create Sep 18, 2025 •

edited

Loading