232 persistent scan window with live feed #21
Conversation
… to clear the feed when a scan isnt running and logs are present
…got detected in a scan
There was a problem hiding this comment.
Pull Request Overview
This pull request enhances the scan results workflow by adding a "Clear feed" button to the scan tab and refining the scan completion user experience. The changes make the live feed management more interactive and improve navigation after scan completion.
- Added a "Clear feed" button that allows users to manually clear the scan live feed and reset difference count
- Refined scan completion dialogs to prompt users to view results regardless of whether differences were found
- Simplified exception handling in ScanService by removing explicit 404 error handling
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| HomeScreen.form | Added "Clear feed" button to UI layout and adjusted grid layout to accommodate new component |
| HomeScreen.java | Added clearFeedButton field, getter method, and updated layout constraints for new button |
| StringConstants.java | Updated scan completion messages to consistently offer viewing results for both scenarios |
| HomePresenter.java | Implemented clear feed functionality, refined visibility logic, and improved scan completion workflow |
| ScanService.java | Removed explicit 404 error handling to return empty lists instead of throwing exceptions |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| screen.getLiveFeedText().setText(""); | ||
| // Reset diff count for the next scan | ||
| totalDiffCount = 0; | ||
| // Clear the live feed text area in preparation for the next scan |
There was a problem hiding this comment.
[nitpick] Lines 312 and 314 could be reordered for better logical flow. Consider resetting totalDiffCount before clearing the text area, as the count reset is logically independent of the UI update.
| // Clear the live feed text area in preparation for the next scan | |
| // Update the live feed diff count in preparation for the next scan |
pwgit-create
left a comment
pwgit-create
left a comment
There was a problem hiding this comment.
After testing the PR code, we found it to be exactly what we wanted and needed. :)
While I recommend following the suggestions from GitHub Copilot (which are valid), I won't hold this great PR hostage.
Good work Stefan! 💠
This pull request introduces improvements to the scan results workflow and enhances the live feed UI in the application. The main changes include a new "Clear feed" button for the scan live feed, refined scan completion dialogs, and better handling of UI visibility for scan-related components. Additionally, some exception handling logic was simplified in the scan service. Below are the most important changes grouped by theme:
Live Feed UI Enhancements:
HomeScreen.form,HomeScreen.java,HomePresenter.java) [1] [2] [3] [4] [5] [6]HomeScreen.form,HomeScreen.java) [1] [2] [3] [4] [5] [6] [7] [8]Scan Completion Workflow Improvements:
HomePresenter.java,StringConstants.java) [1] [2] [3]Service Exception Handling Simplification:
ScanService: removed explicit handling for 404 errors in scan-related service methods so that missing data now results in an empty list rather than an exception. (ScanService.java) [1] [2] [3]These changes collectively improve user experience by making scan results and live feed management clearer and more interactive, while also streamlining backend error handling.
When this PR is approved and merged, I'll do a Develop -> Master PR and release the this plus last thing i added as 0.3.1