Skip to content

Conversation

@lilstiffy
Copy link
Contributor

This pull request refactors the UI and logic for directory creation and improves consistency in user-facing messages. It updates the layout of the Home and New Directory screens, sets sensible defaults, and centralizes string constants for better maintainability.

UI layout and usability improvements:

  • The Home screen layout is simplified by removing the editDirectoryButton and reducing the grid to a single column, making the interface cleaner and focusing on the "New directory" action. (HomeScreen.form, HomeScreen.java) [1] [2] [3]
  • The New Directory screen layout is refactored to group "Create" and "Cancel" buttons together at the bottom, and the grid row count is reduced for a more compact design. (NewDirectoryScreen.form, NewDirectoryScreen.java) [1] [2] [3]
  • The "Include subdirectories" and "Make directory active" checkboxes now default to selected, streamlining the directory creation process for typical use cases. (NewDirectoryScreen.form, NewDirectoryScreen.java) [1] [2] [3]

Consistency and maintainability:

  • All user-facing strings related to directory creation (success, error, no path selected) and generic dialog titles ("Success", "Error") are moved to the centralized StringConstants class, reducing duplication and making localization easier. (StringConstants.java, NewDirectoryController.java) [1] [2] [3] [4] [5]
  • The logic for displaying messages in the New Directory workflow now uses these constants for both content and dialog titles, ensuring consistent terminology throughout the app. (NewDirectoryController.java) [1] [2]

Since this already was in the app I used the ticket to verify everything working as intended and did some minor improvements and cleanup

@lilstiffy lilstiffy self-assigned this Sep 28, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request refactors the directory creation UI and improves consistency by centralizing user-facing strings. It updates the layout of screens to be more compact and user-friendly, sets better defaults for checkboxes, and consolidates string constants for maintainability.

  • UI layout improvements: simplified Home screen by removing edit button and reorganized New Directory screen with buttons grouped at bottom
  • Better defaults: checkboxes for "Include subdirectories" and "Make directory active" now default to selected
  • String consistency: moved all directory creation messages to centralized StringConstants class

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

File Description
HomeScreen.form, HomeScreen.java Removed edit directory button and simplified layout to single column grid
NewDirectoryScreen.form, NewDirectoryScreen.java Reorganized layout to group Create/Cancel buttons at bottom and set checkbox defaults to selected
StringConstants.java Added centralized constants for success/error dialog titles and directory creation messages
NewDirectoryController.java Updated to use centralized string constants for all user-facing messages

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@lilstiffy lilstiffy linked an issue Sep 28, 2025 that may be closed by this pull request
5 tasks
Copy link
Contributor

@pwgit-create pwgit-create left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect 💯

@lilstiffy lilstiffy merged commit 0595445 into develop Sep 29, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Screen for Viewing and Creating New Monitored Directory

3 participants