239 implement quarantine function for backend server #248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Changed text in constants and log prints - Changed Java Docs - Added File-Quarantine Artifact into dependency’s - Bumped version number to pom.xml into 1.4 for an upcoming release
… into related service packages - Added Serial annotation to all PWSS Backend Annotations - Bumped serial number to 2 for the exiting Exception Classes - Created File Isolation Component - Added two methods in FileService - Created File Controller - added 2 endpoints - updated the `FileController` class with JavaDoc comments and Swagger annotations - added JavaDocs and Swagger annotations to the `QuarantineFileRequest` class - enhanced the `UnQurantineFileRequest` class with JavaDoc comments and Swagger annotations - Created 2 new Exception classes - Added new logger entry into logback.xml - Added 3 new entries into .gitignore
lilstiffy
reviewed
Oct 6, 2025
...ty-Scanner/src/main/java/org/pwss/file_integrity_scanner/controller/file/FileController.java
Show resolved
Hide resolved
lilstiffy
reviewed
Oct 6, 2025
.../dsr/domain/file_integrity_scanner/model/request/file_controller/UnQurantineFileRequest.java
Show resolved
Hide resolved
lilstiffy
reviewed
Oct 6, 2025
...s/file_integrity_scanner/dsr/repository/file_integrity_scanner/diff/IntegrityRepository.java
Show resolved
Hide resolved
lilstiffy
reviewed
Oct 6, 2025
...rg/pwss/file_integrity_scanner/dsr/service/file_integrity_scanner/diff/IntegrityService.java
Show resolved
Hide resolved
lilstiffy
reviewed
Oct 6, 2025
...s/file_integrity_scanner/dsr/service/file_integrity_scanner/file/FileIsolationComponent.java
Show resolved
Hide resolved
lilstiffy
reviewed
Oct 6, 2025
...s/file_integrity_scanner/dsr/service/file_integrity_scanner/file/FileIsolationComponent.java
Show resolved
Hide resolved
lilstiffy
reviewed
Oct 6, 2025
...ava/org/pwss/file_integrity_scanner/dsr/service/file_integrity_scanner/file/FileService.java
Outdated
Show resolved
Hide resolved
lilstiffy
reviewed
Oct 6, 2025
| log.error("{} has no diffs and can not be quarantined", file.getBasename()); | ||
| throw new QuarantineFailedException( | ||
| "File has no diffs and can not be quarantined"); | ||
| } |
Collaborator
There was a problem hiding this comment.
Great safe guard 🛡️
We like our users to avoid accidents 🥇
lilstiffy
reviewed
Oct 6, 2025
...grity-Scanner/src/main/java/org/pwss/file_integrity_scanner/dsr/service/PWSSbaseService.java
Show resolved
Hide resolved
lilstiffy
reviewed
Oct 6, 2025
| return true; | ||
| } | ||
|
|
||
| // Basic pattern to detect common injection patterns. This is not foolproof. |
Collaborator
There was a problem hiding this comment.
Not foolproof but miles better than nothing! 🥇
Contributor
Author
There was a problem hiding this comment.
What is foolproof in the world of IT-Security, my dear friend? Yes, better than nothing. In a world where people are truthful about IT, this validation method would still fetch a significant price. You and I are both honest workers and humans. The reason why I enjoy working on a project with you, Comrade Stefan, is because of that! @lilstiffy
Collaborator
There was a problem hiding this comment.
Exactly comrade, you put it well!
I love the validation methods 🤩
lilstiffy
approved these changes
Oct 6, 2025
Collaborator
lilstiffy
left a comment
lilstiffy
left a comment
There was a problem hiding this comment.
Best PR to date, you really came back strong after the sickness! 🥇
My reaction to the PR:
lilstiffy
deleted the
239-implement-quarantine-function-for-backend-server
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stefan, I hope this pull request brings you happiness 😃