Scan speed improvement#369
Merged
Merged
Conversation
Patch update for dependency comment fix
…h computation * Upgraded the dependency algorithm-hash-extraction from version 1.2.8 to 1.2.9 * Added ParallelFileHashHandler for parallel hash computation of large files * Updated FileHashComputer to use parallel processing when computing hashes * Modified ScanServiceImpl to initialize and shutdown parallel hash processors * Added debugging log level for lib.pwss.hash.file_hash_handler.parallel package This change improves performance by utilizing parallel processing for file hash computations, especially for larger files.
* Updated project version from 1.8.5 to 1.9 in pom.xml * Changed log level for lib.pwss.hash.file_hash_handler.parallel package from DEBUG to ERROR in logback.xml This change prepares the project for a new release with improved logging configuration.
* Removed unused `import lib.pwss.hash.ParallelFileHash;` in FileHashComputer.java This cleanup removes an unnecessary import to keep the codebase tidy and improve maintainability.
lilstiffy
approved these changes
May 23, 2026
Collaborator
lilstiffy
left a comment
lilstiffy
left a comment
There was a problem hiding this comment.
No blocking issues found, looks really solid to my eyes 👀
The >2x performance improvement makes this a super solid update.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces parallel hash computation to improve performance when scanning large files in the File Integrity Scanner. The main changes include integrating a new
ParallelFileHashHandler, updating the hash computation logic to use parallel processing for large files, and ensuring proper initialization and shutdown of parallel resources during scan operations.Parallel hash computation integration:
ParallelFileHashHandlertoFileHashComputer, with logic to use it for large files and on out-of-memory errors, replacing previous single-threaded handling. [1] [2] [3]initializeParallelHashing) and shutdown (shutdownParallelHashProcessor) methods for parallel hash resources inFileHashComputer.Scan workflow updates:
ScanServiceImplto initialize parallel hashing before scans and shut down parallel hash resources after scans complete. [1] [2] [3]Dependency and configuration updates:
algorithm-hash-extractiondependency version to1.2.9and updated project version to1.9inpom.xml. [1] [2]lib.pwss.hash.file_hash_handler.parallelinlogback.xmlto control logging from the new parallel handler.