Skip to content

fix race condition in shader downloads#2258

Merged
mfiess merged 1 commit intopxscene:_jscfrom
madanagopalt:race
Apr 9, 2020
Merged

fix race condition in shader downloads#2258
mfiess merged 1 commit intopxscene:_jscfrom
madanagopalt:race

Conversation

@madanagopalt
Copy link
Contributor

No description provided.

@FitzerIRL
Copy link
Contributor

Thanks !

@codecov
Copy link

codecov bot commented Apr 7, 2020

Codecov Report

Merging #2258 into _jsc will decrease coverage by 0.15%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             _jsc    #2258      +/-   ##
==========================================
- Coverage   69.79%   69.63%   -0.16%     
==========================================
  Files         156      156              
  Lines       25622    25688      +66     
==========================================
+ Hits        17883    17888       +5     
- Misses       7739     7800      +61     
Impacted Files Coverage Δ
examples/pxScene2d/src/pxShaderResource.h 100.00% <ø> (ø)
examples/pxScene2d/src/pxShaderResource.cpp 84.33% <100.00%> (+0.14%) ⬆️
src/rtFileDownloader.cpp 70.16% <0.00%> (-0.09%) ⬇️
src/rtScriptJSC/rtJSCBindings.cpp 0.00% <0.00%> (ø)
examples/pxScene2d/src/pxScene2d.cpp 74.25% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2685ca1...60117de. Read the comment docs.

@mfiess mfiess merged commit accc3ba into pxscene:_jsc Apr 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants