Add possibility to extend blocks of the comment template #21
Conversation
Coverage reportThe coverage rate went from
Diff Coverage details (click to unfold)coverage_comment/settings.py
coverage_comment/main.py
coverage_comment/template.py
|
Co-authored-by: Joachim Jablon <ewjoachim@gmail.com>
|
I've started working on a PR-on-your-PR to address different points, I'll try to post it in the close future. Being sick makes it complated to evaluate how much clear-mind time I'll have on my hands in the next days (and how much I'll dedicate to coding 😅 ) |
|
https://github.com/kieferro/python-coverage-comment-action/pull/2 < the WIP. If you like proper code and all, don't look yet :) |
|
@kieferro aaaaand done. I've reworked the PR and added my suggestions (working with blocks and template inheritance, documentation, etc). Also, I included a fix for the issue that currently makes the CI red (it's unrelated. also, due to the way the CI is set up, and the nature of the issue, it will only go green again after we merge :( ) |
…nrelated changes * [Unrelated] Missing annotations * Add plenty of blocks in the template * get_markdown_comment supports template inheritance * Update call in main * (Remove extra test added in main. Sorry ^^' ) * Define COMMENT_TEMPLATE in the settings * Documentation * [Unrelated] Fixing error that makes the CI red.
kieferro
changed the title
2 participants
This adds the functionality for the
COMMENT_TEMPLATEparameter as discussed in #11. Also, this parameter has been added to the README.