Skip to content

Conversation

@madebr
Copy link
Contributor

@madebr madebr commented Apr 1, 2025

Wayland does not support changing the icon or position of a window, so mark those tests as expected failures.

PR Description

Merge Checklist

  • the PR has been reviewed and all comments are resolved
  • all CI checks pass
  • (if applicable): the PR description includes the phrase closes #<issue-number> to automatically close an issue
  • (if applicable): bug fixes, new features, or API changes are documented in news.rst

@a-hurst
Copy link
Member

a-hurst commented Apr 2, 2025

Fantastic, thanks so much!

@a-hurst a-hurst merged commit 6414ee1 into py-sdl:master Apr 2, 2025
33 checks passed
@madebr madebr deleted the wayland-changes branch April 2, 2025 16:16
@madebr
Copy link
Contributor Author

madebr commented Apr 2, 2025

py-sdl2's tests now 100% succeed when using the x11 and wayland video driver.

The test suite fails when using the dummy video driver, but that also happens with SDL2, so I did not look into those.
I've also not tried to run the test suite on Windows or macOS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants