migrate from setup.* to pyproject.toml #52
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The zip_safe and test_suite parameters that are still used there are deprecated upstream.
dbarnett
reviewed
Aug 24, 2024
dbarnett
reviewed
Aug 24, 2024
|
Had a skim through (since I was just about to send a PR with the same change 😅 ), changes all look fine to me. Fun fact: there are conversion tools setuptools-py2cfg + ini2toml that work pretty well for semi-automating this conversion. See https://stackoverflow.com/a/73830494. |
|
I have some in-progress work on proper doc. I’ll create a PR later today with what’s done so far so we can iterate. |
dbarnett
approved these changes
Aug 25, 2024
|
This ended up being written organically. I've reviewed the content here, and added a few bits that were missing. Thanks for the work, and my apologies that I didn't end up merging it. |
da4089
added a commit
to da4089/vobject
that referenced
this pull request
Jan 3, 2025
This was based on a review of PR py-vobject#52 from @lucc, reviewed by @dbarnett, that I didn't end up using as I set up the v1.0 build. With this change, I've pulled in the things in @lucc's PR that weren't there already.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know if you are interested in this before the 0.9.8 release. Otherwise we can keep it here until then.