Skip to content

Fixed Issue#129 #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 23, 2024
Merged

Fixed Issue#129 #161

merged 2 commits into from
Jan 23, 2024

Conversation

@zhi-yi-huang
Copy link
Collaborator

@zhi-yi-huang zhi-yi-huang commented Jan 22, 2024

Updates

  • Fixed an issue on updating the separated set.
  • Added a test for updating the separated set.

Description

The sepset had been initialized with an empty set. But it should be recorded in cg.sepset when x and y are d-separated, given by sepset. Otherwise, sepset (the empty set) will be recorded in cg.sepset.

Test Plan

python -m unittest tests.TestPC # should pass
python -m unittest tests.TestSkeletonDiscovery # should pass

image

@kunwuz
Copy link
Collaborator

kunwuz commented Jan 23, 2024

Thanks for the fix!

@kunwuz kunwuz merged commit 0991c80 into py-why:main Jan 23, 2024
@kunwuz kunwuz mentioned this pull request Jan 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kunwuz kunwuz kunwuz approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zhi-yi-huang @kunwuz