Add orientation rules 567 for Augmented FCI #194
Conversation
| if edge.get_endpoint1() == Endpoint.CIRCLE and edge.get_endpoint2() == Endpoint.CIRCLE: | ||
| return edge.get_node2() | ||
| elif node == edge.get_node2(): | ||
| if edge.get_endpoint1() == Endpoint.CIRCLE or edge.get_endpoint2() == Endpoint.CIRCLE: |
There was a problem hiding this comment.
Should the if statement condition here be an AND condition?
| for node_D in b_circle_adj_nodes_set: | ||
| if graph.is_adjacent_to(node_A, node_D): | ||
| continue | ||
| path = GetUncoveredCirclePath(node_from=node_C, node_to=node_D, G=graph) |
There was a problem hiding this comment.
Will there be multiple uncovered circle paths? Perhaps we can change return to yield in line 105 to make it a generator.
There was a problem hiding this comment.
Thank you for the suggestion. This part is modified accordingly.
| if graph.is_adjacent_to(node_A, node_D): | ||
| continue | ||
| path = GetUncoveredCirclePath(node_from=node_C, node_to=node_D, G=graph) | ||
| if path is not None: |
There was a problem hiding this comment.
The edge between alpha and beta is not modified inside the if statement. Perhaps the edge between alpha and beta can be modified based on change_flag outside the if statement.
There was a problem hiding this comment.
I think the edge between alpha and beta will only be modified "if there is an uncovered circle path p s.t. xxx", so then change_flag should still be kept inside the if statement?
There was a problem hiding this comment.
Yes, I mean the edge between alpha and beta hasn't been modified. If change_flag is set to True, then there is an uncovered circle path between alpha and beta, and the edge between alpha and beta needs to be modified. Perhaps a change_flag can be set outside the for loop on line 443 to indicate that rule5 modifies graph G. And a local_change_flag can be set inside the for loop on line 446 to indicate that there is an uncovered circle path between alpha and beta, and the edge between alpha and beta can be modified according to the local_change_flag inside the for loop.
There was a problem hiding this comment.
I have added the part to allow orienting multiple uncovered circle paths between alpha and beta, and moved the change_flag accordingly. Now it is changed only when double tails are oriented.
Signed-off-by: Zhiyi Huang <83860323+zhi-yi-huang@users.noreply.github.com>
Signed-off-by: ZhiyiHuang <huangzhiyi.chn@gmail.com>
zhi-yi-huang
left a comment
zhi-yi-huang
left a comment
There was a problem hiding this comment.
Thanks for adding the orientation rules for FCI. I have fixed a minor bug in rule 5 and regenerates the benchmark results for FCI.
python -m unittest tests.TestFCI # should pass
|
Thanks a lot!! @EvieQ01 @zhi-yi-huang |
3 participants
Add orientation rules 567 for Augmented FCI according to [1]. These rules are related to undirected edges, in order to deal with selection bias. (when there's no selection, they can be ignored)
[1] Jiji Zhang, "On the completeness of orientation rules for causal discovery in the presence of latent confounders and selection bias", 2008