Skip to content

Conversation

@OliverSchacht
Copy link
Contributor

@OliverSchacht OliverSchacht commented Oct 21, 2024

I am adding two variants of the kernel-based conditional independence test, that are aiming at improved computational efficiency.

Namely:

I also added two easy unit tests checking the implementation.
I added the algorithms to the cit class, so they can be used with the PC algorithm for causal discovery.

Happy to hear your feedback!

Edit: I think I got something with the signature wrong here... followed the guide but I think something is wrong.

Boyle-Coffee and others added 30 commits October 21, 2024 14:56
Signed-off-by: Oliver Schacht <oliver.schacht@uni-hamburg.de>
Signed-off-by: Oliver Schacht <oliver.schacht@uni-hamburg.de>
Signed-off-by: Oliver Schacht <oliver.schacht@uni-hamburg.de>
Signed-off-by: Oliver Schacht <oliver.schacht@uni-hamburg.de>
Signed-off-by: Oliver Schacht <oliver.schacht@uni-hamburg.de>
Signed-off-by: Oliver Schacht <oliver.schacht@uni-hamburg.de>
Signed-off-by: Oliver Schacht <oliver.schacht@uni-hamburg.de>
Signed-off-by: Oliver Schacht <oliver.schacht@uni-hamburg.de>
Signed-off-by: kunwuz <514397511@qq.com>
Signed-off-by: Oliver Schacht <oliver.schacht@uni-hamburg.de>
Signed-off-by: Oliver Schacht <oliver.schacht@uni-hamburg.de>
Signed-off-by: Oliver Schacht <oliver.schacht@uni-hamburg.de>
Signed-off-by: Oliver Schacht <oliver.schacht@uni-hamburg.de>
Signed-off-by: Oliver Schacht <oliver.schacht@uni-hamburg.de>
Signed-off-by: Oliver Schacht <oliver.schacht@uni-hamburg.de>
Signed-off-by: Oliver Schacht <oliver.schacht@uni-hamburg.de>
Signed-off-by: Oliver Schacht <oliver.schacht@uni-hamburg.de>
Signed-off-by: Oliver Schacht <oliver.schacht@uni-hamburg.de>
Signed-off-by: Oliver Schacht <oliver.schacht@uni-hamburg.de>
Signed-off-by: Oliver Schacht <oliver.schacht@uni-hamburg.de>
Signed-off-by: Oliver Schacht <oliver.schacht@uni-hamburg.de>
Signed-off-by: Oliver Schacht <oliver.schacht@uni-hamburg.de>
Signed-off-by: Oliver Schacht <oliver.schacht@uni-hamburg.de>
Signed-off-by: Oliver Schacht <oliver.schacht@uni-hamburg.de>
Signed-off-by: Oliver Schacht <oliver.schacht@uni-hamburg.de>
Signed-off-by: Oliver Schacht <oliver.schacht@uni-hamburg.de>
Signed-off-by: Oliver Schacht <oliver.schacht@uni-hamburg.de>
Signed-off-by: Oliver Schacht <oliver.schacht@uni-hamburg.de>
Signed-off-by: Oliver Schacht <oliver.schacht@uni-hamburg.de>
Changed np.int (deprecated) to int according to error message in numpy.

Signed-off-by: Filip Edström <filip.edstrom@gmail.com>
Signed-off-by: Oliver Schacht <oliver.schacht@uni-hamburg.de>
Signed-off-by: Oliver Schacht <oliver.schacht@uni-hamburg.de>
bja43 and others added 25 commits October 21, 2024 14:56
Signed-off-by: Oliver Schacht <oliver.schacht@uni-hamburg.de>
Signed-off-by: Oliver Schacht <oliver.schacht@uni-hamburg.de>
Signed-off-by: Oliver Schacht <oliver.schacht@uni-hamburg.de>
Signed-off-by: Oliver Schacht <oliver.schacht@uni-hamburg.de>
Signed-off-by: Oliver Schacht <oliver.schacht@uni-hamburg.de>
Signed-off-by: Oliver Schacht <oliver.schacht@uni-hamburg.de>
Signed-off-by: Oliver Schacht <oliver.schacht@uni-hamburg.de>
Signed-off-by: ZhiyiHuang <huangzhiyi.chn@gmail.com>
Signed-off-by: Oliver Schacht <oliver.schacht@uni-hamburg.de>
Signed-off-by: Oliver Schacht <oliver.schacht@uni-hamburg.de>
Signed-off-by: Oliver Schacht <oliver.schacht@uni-hamburg.de>
Signed-off-by: Oliver Schacht <oliver.schacht@uni-hamburg.de>
Signed-off-by: Oliver Schacht <oliver.schacht@uni-hamburg.de>
Signed-off-by: Zhiyi Huang <83860323+zhi-yi-huang@users.noreply.github.com>
Signed-off-by: Oliver Schacht <oliver.schacht@uni-hamburg.de>
Signed-off-by: ZhiyiHuang <huangzhiyi.chn@gmail.com>
Signed-off-by: Oliver Schacht <oliver.schacht@uni-hamburg.de>
Signed-off-by: Oliver Schacht <oliver.schacht@uni-hamburg.de>
Signed-off-by: Oliver Schacht <oliver.schacht@uni-hamburg.de>
Signed-off-by: Oliver Schacht <oliver.schacht@uni-hamburg.de>
Signed-off-by: Oliver Schacht <oliver.schacht@uni-hamburg.de>
Signed-off-by: OliverSchacht <65898638+OliverSchacht@users.noreply.github.com>
Signed-off-by: Oliver Schacht <oliver.schacht@uni-hamburg.de>
Signed-off-by: OliverSchacht <65898638+OliverSchacht@users.noreply.github.com>
Signed-off-by: Oliver Schacht <oliver.schacht@uni-hamburg.de>
Signed-off-by: OliverSchacht <65898638+OliverSchacht@users.noreply.github.com>
Signed-off-by: Oliver Schacht <oliver.schacht@uni-hamburg.de>
Signed-off-by: Oliver Schacht <oliver.schacht@uni-hamburg.de>
Signed-off-by: Oliver Schacht <oliver.schacht@uni-hamburg.de>
Signed-off-by: OliverSchacht <65898638+OliverSchacht@users.noreply.github.com>
Signed-off-by: Oliver Schacht <oliver.schacht@uni-hamburg.de>
Signed-off-by: Oliver Schacht <oliver.schacht@uni-hamburg.de>
@kunwuz
Copy link
Collaborator

kunwuz commented Oct 21, 2024

Hi Oliver, thanks for these implementations—they're really interesting and helpful! If possible, could you create a new PR or modify this one to include only the files with changes? It seems there's an issue with the commit history. You can ignore the signature; I can handle that manually.

@OliverSchacht
Copy link
Contributor Author

Hi!

Thanks for the feedback. Yes, I think I messed everything up by trying to rebase and sign. Never worked with that before...
I will make a clean branch with only my additions and create a new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.