-
Notifications
You must be signed in to change notification settings - Fork 231
Add two variants of the KCI test #201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Oliver Schacht <oliver.schacht@uni-hamburg.de>
Signed-off-by: Oliver Schacht <oliver.schacht@uni-hamburg.de>
Signed-off-by: Oliver Schacht <oliver.schacht@uni-hamburg.de>
Signed-off-by: Oliver Schacht <oliver.schacht@uni-hamburg.de>
Signed-off-by: Oliver Schacht <oliver.schacht@uni-hamburg.de>
Signed-off-by: Oliver Schacht <oliver.schacht@uni-hamburg.de>
Signed-off-by: Oliver Schacht <oliver.schacht@uni-hamburg.de>
Signed-off-by: Oliver Schacht <oliver.schacht@uni-hamburg.de>
Signed-off-by: kunwuz <514397511@qq.com> Signed-off-by: Oliver Schacht <oliver.schacht@uni-hamburg.de>
Signed-off-by: Oliver Schacht <oliver.schacht@uni-hamburg.de>
Signed-off-by: Oliver Schacht <oliver.schacht@uni-hamburg.de>
Signed-off-by: Oliver Schacht <oliver.schacht@uni-hamburg.de>
Signed-off-by: Oliver Schacht <oliver.schacht@uni-hamburg.de>
Signed-off-by: Oliver Schacht <oliver.schacht@uni-hamburg.de>
Signed-off-by: Oliver Schacht <oliver.schacht@uni-hamburg.de>
Signed-off-by: Oliver Schacht <oliver.schacht@uni-hamburg.de>
Signed-off-by: Oliver Schacht <oliver.schacht@uni-hamburg.de>
Signed-off-by: Oliver Schacht <oliver.schacht@uni-hamburg.de>
Signed-off-by: Oliver Schacht <oliver.schacht@uni-hamburg.de>
Signed-off-by: Oliver Schacht <oliver.schacht@uni-hamburg.de>
Signed-off-by: Oliver Schacht <oliver.schacht@uni-hamburg.de>
Signed-off-by: Oliver Schacht <oliver.schacht@uni-hamburg.de>
Signed-off-by: Oliver Schacht <oliver.schacht@uni-hamburg.de>
Signed-off-by: Oliver Schacht <oliver.schacht@uni-hamburg.de>
Signed-off-by: Oliver Schacht <oliver.schacht@uni-hamburg.de>
Signed-off-by: Oliver Schacht <oliver.schacht@uni-hamburg.de>
Signed-off-by: Oliver Schacht <oliver.schacht@uni-hamburg.de>
Signed-off-by: Oliver Schacht <oliver.schacht@uni-hamburg.de>
Changed np.int (deprecated) to int according to error message in numpy. Signed-off-by: Filip Edström <filip.edstrom@gmail.com> Signed-off-by: Oliver Schacht <oliver.schacht@uni-hamburg.de>
Signed-off-by: Oliver Schacht <oliver.schacht@uni-hamburg.de>
Signed-off-by: Oliver Schacht <oliver.schacht@uni-hamburg.de>
Signed-off-by: Oliver Schacht <oliver.schacht@uni-hamburg.de>
Signed-off-by: Oliver Schacht <oliver.schacht@uni-hamburg.de>
Signed-off-by: Oliver Schacht <oliver.schacht@uni-hamburg.de>
Signed-off-by: Oliver Schacht <oliver.schacht@uni-hamburg.de>
Signed-off-by: Oliver Schacht <oliver.schacht@uni-hamburg.de>
Signed-off-by: Oliver Schacht <oliver.schacht@uni-hamburg.de>
Signed-off-by: ZhiyiHuang <huangzhiyi.chn@gmail.com> Signed-off-by: Oliver Schacht <oliver.schacht@uni-hamburg.de>
Signed-off-by: Oliver Schacht <oliver.schacht@uni-hamburg.de>
Signed-off-by: Oliver Schacht <oliver.schacht@uni-hamburg.de>
Signed-off-by: Oliver Schacht <oliver.schacht@uni-hamburg.de>
Signed-off-by: Oliver Schacht <oliver.schacht@uni-hamburg.de>
Signed-off-by: Zhiyi Huang <83860323+zhi-yi-huang@users.noreply.github.com> Signed-off-by: Oliver Schacht <oliver.schacht@uni-hamburg.de>
Signed-off-by: ZhiyiHuang <huangzhiyi.chn@gmail.com> Signed-off-by: Oliver Schacht <oliver.schacht@uni-hamburg.de>
Signed-off-by: Oliver Schacht <oliver.schacht@uni-hamburg.de>
Signed-off-by: Oliver Schacht <oliver.schacht@uni-hamburg.de>
Signed-off-by: Oliver Schacht <oliver.schacht@uni-hamburg.de>
Signed-off-by: Oliver Schacht <oliver.schacht@uni-hamburg.de>
Signed-off-by: OliverSchacht <65898638+OliverSchacht@users.noreply.github.com> Signed-off-by: Oliver Schacht <oliver.schacht@uni-hamburg.de>
Signed-off-by: OliverSchacht <65898638+OliverSchacht@users.noreply.github.com> Signed-off-by: Oliver Schacht <oliver.schacht@uni-hamburg.de>
Signed-off-by: OliverSchacht <65898638+OliverSchacht@users.noreply.github.com> Signed-off-by: Oliver Schacht <oliver.schacht@uni-hamburg.de>
Signed-off-by: Oliver Schacht <oliver.schacht@uni-hamburg.de>
Signed-off-by: OliverSchacht <65898638+OliverSchacht@users.noreply.github.com> Signed-off-by: Oliver Schacht <oliver.schacht@uni-hamburg.de>
Signed-off-by: Oliver Schacht <oliver.schacht@uni-hamburg.de>
|
Hi Oliver, thanks for these implementations—they're really interesting and helpful! If possible, could you create a new PR or modify this one to include only the files with changes? It seems there's an issue with the commit history. You can ignore the signature; I can handle that manually. |
|
Hi! Thanks for the feedback. Yes, I think I messed everything up by trying to rebase and sign. Never worked with that before... |
I am adding two variants of the kernel-based conditional independence test, that are aiming at improved computational efficiency.
Namely:
I also added two easy unit tests checking the implementation.
I added the algorithms to the cit class, so they can be used with the PC algorithm for causal discovery.
Happy to hear your feedback!
Edit: I think I got something with the signature wrong here... followed the guide but I think something is wrong.