Skip to content

Conversation

@emoen
Copy link
Contributor

@emoen emoen commented Jan 3, 2025

What if the correlation matrix is singular? In ExactSearch.bic_exact_search() handle residuals array is empty. It means that the least squares problem does not have a unique solution or has no degrees of freedom left to compute residuals. Return BIC score of negative infinity.

Signed-off-by: Endre Moen <endremoen@hotmail.com>
Copy link
Collaborator

@kunwuz kunwuz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@kunwuz kunwuz merged commit b07c316 into py-why:main Jan 3, 2025
2 checks passed
@emoen emoen deleted the fix/exact_search_bic_is_float branch January 3, 2025 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants