Skip to content

Conversation

@ignavierng
Copy link
Contributor

Updates

  • Refactored unit tests for Astar and DP into a single function for exact search

Test Plan

python -m unittest tests.TestExactSearch # should pass

TestExactSearch

Copy link
Contributor

@tofuwen tofuwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, great work!
Btw, you will also change other tests to remove the sys.path.append(), right?

cc @kunwuz to merge this PR.

@kunwuz kunwuz merged commit 5b30aad into py-why:main Jul 15, 2022
@ignavierng
Copy link
Contributor Author

Yes, I will change the other tests to update the data path and remove sys.path.append(), so that in the future we should perhaps run python -m unittest tests.FileName, rather than cd-ing into tests folder and running python -m unittest FileName, the latter which imports causallearn (if exists) from pip installed packages instead of local one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants