Update electron_counting.py #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed two bugs: Random sampling of frames for histogram fitting of dark reference (line 78) sometimes overshot array bounds. Center of mass was being performed over a 2x2 local region (line 194-196) and this has been corrected to a 3x3 region - typical Python array bounds gotcha
Contributor
Author
|
Hi Ben, Would you mind pulling these changes to the electron counting routine in preparation for our skype discussion? |
sezelt
referenced
this pull request
in sezelt/py4DSTEM
Aug 17, 2021
simple pointlistarray matching framework
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed two bugs:
Random sampling of frames for histogram fitting of dark reference (line 78) sometimes overshot array bounds.
Center of mass was being performed over a 2x2 local region (line 194-196) and this has been corrected to a 3x3 region - typical Python array bounds gotcha