Skip to content

Conversation

@sezelt
Copy link
Member

@sezelt sezelt commented Aug 23, 2023

Conditional on approving #499, it would make sense to enforce black styling on any updates to the repo. This should also prevent the situation where PRs contain a mix of new code and re-formatting of old code, which makes changes harder to comprehend.

@sezelt
Copy link
Member Author

sezelt commented Aug 23, 2023

The black action obviously fails at the moment, since the base branch isn't formatted!

If #499 is approved, I will merge dev into this PR to confirm the check runs properly before marking ready for review.

@alex-rakowski alex-rakowski mentioned this pull request Aug 29, 2023
# For more information see: https://help.github.com/actions/language-and-framework-guides/using-python-with-github-actions

name: Python application
name: Check module can be imported
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THANK YOU

@sezelt sezelt marked this pull request as ready for review August 29, 2023 01:34
@sezelt sezelt merged commit d9daf5d into py4dstem:dev Aug 29, 2023
@sezelt sezelt deleted the black-gh-action branch August 29, 2023 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants