Adding grain clustering for ACOM #525
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Example functionality in notebook: https://drive.google.com/file/d/1umf1ufJppU6wTV_ZNni-mqbSivVWeaoO/view?usp=sharing |
sezelt
approved these changes
Oct 5, 2023
Member
sezelt
left a comment
sezelt
left a comment
There was a problem hiding this comment.
I've made some changes, to add missing documentation in old functions and to switch the progressbar to be tqdm-based. Tested working using the example notebook.
Member
|
I'm not sure why the readthedocs check is failing, @bsavitzky or @alex-rakowski do you have any ideas? Once that is resolved, this is OK to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And a bunch of additional options, like min angle spacing between multiple zone axes. Functionality is shown in the attached notebook.