Skip to content

Conversation

@alex-rakowski
Copy link
Collaborator

This adds dependabot functionality to check and create PRs for updates in our GitHub actions dependencies. Similar to the vulnerability one was raised in #593 .

We could extend this to check pip packages, but I've left this out as it is a more breaking change.

  - package-ecosystem: "pip" # See documentation for possible values
    directory: "/" # Location of package manifests
    schedule:
      interval: "weekly"
      day: "sunday"
      time: "23:00"
    ignore:
      - dependency-name: "tensorflow"
      - dependency-name: "tensorflow-addons"
      

@sezelt
Copy link
Member

sezelt commented Jan 4, 2024

What would actually break if we were to enable checking of pip dependencies?

@alex-rakowski
Copy link
Collaborator Author

alex-rakowski commented Jan 4, 2024 via email

@sezelt
Copy link
Member

sezelt commented Jan 4, 2024

I guess I'm more asking, what will it actually do in that case? Will it open random PRs? Will it make tests fail? In what way will things actually be "broken?"

@alex-rakowski
Copy link
Collaborator Author

alex-rakowski commented Jan 4, 2024 via email

@sezelt
Copy link
Member

sezelt commented Jan 4, 2024

OK in that case, I suppose we don't want to turn on pip packages. For github actions, will this do anything different than what we already have? There seems to be some default level of checking for actions vulnerabilities, since we got that other PR. Is there some severity setting that might be different?

@alex-rakowski
Copy link
Collaborator Author

alex-rakowski commented Jan 5, 2024 via email

Copy link
Member

@bsavitzky bsavitzky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Looks good :)

@bsavitzky bsavitzky merged commit d136d65 into py4dstem:dev Jan 22, 2024
bsavitzky added a commit to bsavitzky/py4DSTEM that referenced this pull request Mar 12, 2024
adding dependabot functionality 

Former-commit-id: d136d65
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants