Skip to content

fix disabled hardware variable save button bug#122

Merged
ThomasAkam merged 1 commit intopyControl:masterfrom
alustig3:hw-save-button
Nov 18, 2024
Merged

fix disabled hardware variable save button bug#122
ThomasAkam merged 1 commit intopyControl:masterfrom
alustig3:hw-save-button

Conversation

@alustig3
Copy link
Contributor

hw_save_button_disabled.mp4

If the hardware variables for multiple setups are being edited, the save button will only become enabled if the last variable in the table has changed. This fixes the bug so that the save button becomes enabled if any of the variables is changed.

If the hardware variables for multiple setups are being edited, the save button will only become enabled if the last variable in the table has changed. This fixes the bug so that the save button becomes enabled if any of the variables is changed.
@alustig3 alustig3 changed the title fix disabled hardware save button bug fix disabled hardware variable save button bug Jun 15, 2024
@ThomasAkam
Copy link
Collaborator

Hi @alustig3, I somehow missed this and just saw it when looking at the repo for something else. Apologies for the very long delay!

@ThomasAkam ThomasAkam merged commit 028a02a into pyControl:master Nov 18, 2024
@alustig3 alustig3 deleted the hw-save-button branch November 18, 2024 22:00
@alustig3
Copy link
Contributor Author

@ThomasAkam, I wanted to mention, for the next time you make a release on GitHub, it might be best to make a fresh release instead of editing the current v2 release. The only reason I say this is because this website can track downloads of the releases, which can be useful. But if you edit a release, the download count gets reset and only shows downloads of the latest version of that release (for instance when v2.0.2 was released as an edit to v2.0.1, all of the v.2.0.1 downloads that were counted were lost and the count was set back to 0).

@ThomasAkam
Copy link
Collaborator

Hi @alustig3, good to know abou that website, I will make sure I only do new releases rather than editing old ones in future.

IsabelDAlessandro pushed a commit to IsabelDAlessandro/pycontrol_code that referenced this pull request Jan 21, 2026
If the hardware variables for multiple setups are being edited, the save button will only become enabled if the last variable in the table has changed. This fixes the bug so that the save button becomes enabled if any of the variables is changed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants