Skip to content

add 2x2 test#28

Merged
malmans2 merged 2 commits intopyNEMO:mainfrom
malmans2:2x2_test
Jun 12, 2021
Merged

add 2x2 test#28
malmans2 merged 2 commits intopyNEMO:mainfrom
malmans2:2x2_test

Conversation

@malmans2
Copy link
Copy Markdown
Member

@malmans2 malmans2 added the tests Improvements or additions to tests label Jun 11, 2021
@malmans2 malmans2 requested a review from a team June 11, 2021 18:50
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 11, 2021

Codecov Report

Merging #28 (fa031b6) into main (34ca3ca) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #28   +/-   ##
=======================================
  Coverage   93.12%   93.12%           
=======================================
  Files           4        4           
  Lines         160      160           
=======================================
  Hits          149      149           
  Misses         11       11           
Flag Coverage Δ
unittests 93.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34ca3ca...fa031b6. Read the comment docs.

from pydomcfg.domzgr.zco import Zco
from pydomcfg.tests.bathymetry import Bathymetry

from .bathymetry import Bathymetry
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same thing, but I think it makes more sense to load it locally.
This is a module that we only use for testing.

Everything else, makes sense to import from the installed package.

@malmans2 malmans2 merged commit 1edcec7 into pyNEMO:main Jun 12, 2021
@malmans2 malmans2 deleted the 2x2_test branch June 13, 2021 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tests Improvements or additions to tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a test to make sure Zco output does not change with x and y

2 participants