-
Notifications
You must be signed in to change notification settings - Fork 74
enh: update dependency page to support pep 735 and uv #584
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+391
−264
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
503e046
enh: update dependency page to support pep 735 and uv
lwasser bda0298
enh: specifiers
lwasser c4daff9
Apply suggestion from @willingc
lwasser 2b7e695
Apply suggestion from @willingc
lwasser 8f628da
Apply suggestion from @ucodery
lwasser 7e85436
Apply suggestion from @ucodery
lwasser 75f8d7c
Apply suggestion from @lwasser
lwasser b367af1
enh: reorg
lwasser c868504
enh: updates to deps page
lwasser d0a0100
enh: updates to deps page
lwasser File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this change makes the diagram a bit misleading now. Dependency Groups do not have to include your package, nor any subset of your package's required dependencies. They certainly can, by including your package just as any other dependency, but they can also be entirely disjointed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right - I can take another stab at this tomorrow - maybe dependency groups are to the side in a small bubble?
so we have optional and your package which overlap as optional is for features. (and sometimes tests? if people include them)
And the dependency groups are development focused - not ever user facing.
Does this sound reasonable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it's kind of awkward because there certainly will be some dependency groups that will be off in their own bubble (formatter environments) but others that will be supersets, like in the old graphic (test environments, generally)