Skip to content

Conversation

@dnerini
Copy link
Member

@dnerini dnerini commented Aug 13, 2019

Following #101, complete refactoring of the LK optical flow method.

The motion.lucaskanade module now only includes a wrapper to the original opencv method (lucaskanade.track_features) which returns sparse vectors and a the main dense_lucaskanade method which returns a motion field.

All others subroutines have been reorganized in few new modules:

  • utils.interpolate module (RBF interpolation)
  • utils.cleansing module (declustering, outlier detection)
  • utils.images module (corner detection, morphological opening)

Corresponding documentation here:
https://pysteps.readthedocs.io/en/refactor_lk/

Note that this branch has been merged with the add_decorators branch.

@dnerini dnerini added this to the release v1.1 milestone Aug 13, 2019
@codecov
Copy link

codecov bot commented Aug 13, 2019

Codecov Report

Merging #110 into master will increase coverage by 0.39%.
The diff coverage is 78.37%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #110      +/-   ##
==========================================
+ Coverage   57.32%   57.72%   +0.39%     
==========================================
  Files          87       91       +4     
  Lines        6465     6753     +288     
==========================================
+ Hits         3706     3898     +192     
- Misses       2759     2855      +96
Impacted Files Coverage Δ
pysteps/tests/test_nowcasts_steps.py 100% <ø> (ø) ⬆️
pysteps/motion/proesmans.py 88.88% <100%> (+7.63%) ⬆️
pysteps/tests/test_interfaces.py 99.12% <100%> (+0.04%) ⬆️
pysteps/utils/__init__.py 100% <100%> (ø) ⬆️
pysteps/utils/cleansing.py 58.58% <58.58%> (ø)
pysteps/utils/interpolate.py 68.25% <68.25%> (ø)
pysteps/tests/test_motion.py 91.39% <70.83%> (-7.2%) ⬇️
pysteps/motion/vet.py 84.45% <75%> (+0.67%) ⬆️
pysteps/utils/images.py 80.48% <80.48%> (ø)
pysteps/motion/lucaskanade.py 87.25% <90%> (+8.8%) ⬆️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8073de8...3ccb17f. Read the comment docs.

Enforece maximum number of characters per line in docstrings
Replace variable names (next was used and this is a reserved keyword).
Copy link
Member

@pulkkins pulkkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!

@aperezhortal aperezhortal changed the title Refactor LK Refactor Optical flow interfaces Aug 16, 2019
@dnerini dnerini merged commit 9bd613f into master Aug 19, 2019
@dnerini dnerini deleted the refactor_LK branch August 22, 2019 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants