-
Notifications
You must be signed in to change notification settings - Fork 184
Refactor Optical flow interfaces #110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The decorator is used in the optical flow functions to check the input_images shape.
Codecov Report
@@ Coverage Diff @@
## master #110 +/- ##
==========================================
+ Coverage 57.32% 57.72% +0.39%
==========================================
Files 87 91 +4
Lines 6465 6753 +288
==========================================
+ Hits 3706 3898 +192
- Misses 2759 2855 +96
Continue to review full report at Codecov.
|
Enforece maximum number of characters per line in docstrings Replace variable names (next was used and this is a reserved keyword).
pulkkins
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work!
Following #101, complete refactoring of the LK optical flow method.
The motion.lucaskanade module now only includes a wrapper to the original opencv method (lucaskanade.track_features) which returns sparse vectors and a the main dense_lucaskanade method which returns a motion field.
All others subroutines have been reorganized in few new modules:
Corresponding documentation here:
https://pysteps.readthedocs.io/en/refactor_lk/
Note that this branch has been merged with the add_decorators branch.