Skip to content

fix: fix composite mode on init#200

Merged
tlambert03 merged 5 commits intopyapp-kit:mainfrom
tlambert03:fix-composite
Aug 23, 2025
Merged

fix: fix composite mode on init#200
tlambert03 merged 5 commits intopyapp-kit:mainfrom
tlambert03:fix-composite

Conversation

@tlambert03
Copy link
Copy Markdown
Member

fixes #197

The core problem was that the whole "guess channel axis" hadn't triggered by the time the canvas was drawn. the example works fine if you pass in an explicit channel axis, so we just need to do a better job of coordinating the timing of that magic.

This gets the example working... but I need to check whether some other things have been broken

@codecov
Copy link
Copy Markdown

codecov bot commented May 28, 2025

Codecov Report

❌ Patch coverage is 94.44444% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 86.07%. Comparing base (e3e94d3) to head (3cdfa92).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/ndv/models/_data_display_model.py 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #200      +/-   ##
==========================================
+ Coverage   85.92%   86.07%   +0.14%     
==========================================
  Files          46       46              
  Lines        5202     5200       -2     
==========================================
+ Hits         4470     4476       +6     
+ Misses        732      724       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tlambert03 tlambert03 marked this pull request as ready for review August 23, 2025 20:15
@tlambert03 tlambert03 added the bug Something isn't working label Aug 23, 2025
@tlambert03 tlambert03 merged commit 35bc88c into pyapp-kit:main Aug 23, 2025
51 checks passed
@tlambert03 tlambert03 deleted the fix-composite branch August 23, 2025 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Setting composite mode in ctor results in broken state

1 participant