Skip to content

fix: ensure hide_sliders runs on the main thread#229

Merged
tlambert03 merged 1 commit intopyapp-kit:mainfrom
tlambert03:ensure-thread
Feb 7, 2026
Merged

fix: ensure hide_sliders runs on the main thread#229
tlambert03 merged 1 commit intopyapp-kit:mainfrom
tlambert03:ensure-thread

Conversation

@tlambert03
Copy link
Copy Markdown
Member

after searching for a while, I don't have a satisfying explanation for why this is happening... but following a dims_changed signal from a custom data wrapper, I'm getting

WARNING: Cannot make QOpenGLContext current in a different thread
zsh: abort      python examples/pymmcore_plus_example.py tensorstore

and this fixes it

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.29%. Comparing base (d60f273) to head (f998b14).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #229      +/-   ##
==========================================
+ Coverage   86.09%   86.29%   +0.19%     
==========================================
  Files          46       46              
  Lines        5208     5209       +1     
==========================================
+ Hits         4484     4495      +11     
+ Misses        724      714      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tlambert03 tlambert03 merged commit a9654db into pyapp-kit:main Feb 7, 2026
52 checks passed
@tlambert03 tlambert03 deleted the ensure-thread branch February 7, 2026 00:10
@tlambert03 tlambert03 added the bug Something isn't working label Feb 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant