Skip to content

fix: prevent flicker on dims_changed#231

Merged
tlambert03 merged 1 commit intopyapp-kit:mainfrom
tlambert03:flicker
Mar 4, 2026
Merged

fix: prevent flicker on dims_changed#231
tlambert03 merged 1 commit intopyapp-kit:mainfrom
tlambert03:flicker

Conversation

@tlambert03
Copy link
Copy Markdown
Member

this fixes unnecessary canvas clearing on dims_changed, and prevents the width of the qt slider labels from jiggling as they change.

before:

Untitled2.mov

after:

Untitled.mov

@tlambert03 tlambert03 changed the title fix: prevent flicker fix: prevent flicker on dims_changed Mar 3, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 3, 2026

Codecov Report

❌ Patch coverage is 70.83333% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.01%. Comparing base (5da7236) to head (c7ed8ef).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/ndv/controllers/_array_viewer.py 30.00% 7 Missing ⚠️

❌ Your patch status has failed because the patch coverage (70.83%) is below the target coverage (85.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #231      +/-   ##
==========================================
- Coverage   86.29%   86.01%   -0.28%     
==========================================
  Files          46       46              
  Lines        5209     5228      +19     
==========================================
+ Hits         4495     4497       +2     
- Misses        714      731      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tlambert03 tlambert03 merged commit 24cb779 into pyapp-kit:main Mar 4, 2026
51 of 52 checks passed
@tlambert03 tlambert03 deleted the flicker branch March 4, 2026 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant