Skip to content

fix: fix misc bugs#243

Merged
tlambert03 merged 6 commits intopyapp-kit:mainfrom
tlambert03:misc-bugs
Mar 8, 2026
Merged

fix: fix misc bugs#243
tlambert03 merged 6 commits intopyapp-kit:mainfrom
tlambert03:misc-bugs

Conversation

@tlambert03
Copy link
Copy Markdown
Member

  1. process_request squeeze removed singleton visible axes — .squeeze() stripped all size-1 dimensions, including visible axes. Replaced with a targeted .reshape(vis_shape) that only collapses non-visible, non-channel dims.

  2. Negative current_index values produced empty slices — _norm_current_index only clamped values exceeding max_val, so -1 passed through and became slice(-1, 0) (empty). Added clamping for val < 0.

  3. _calc_hist_bins crashed on float data — np.iinfo(data.dtype) raises for float dtypes. Now falls back to np.histogram for non-integer data

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.96%. Comparing base (9df4125) to head (8620ac7).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #243      +/-   ##
==========================================
- Coverage   87.05%   86.96%   -0.10%     
==========================================
  Files          46       46              
  Lines        5330     5338       +8     
==========================================
+ Hits         4640     4642       +2     
- Misses        690      696       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tlambert03 tlambert03 merged commit ec734e7 into pyapp-kit:main Mar 8, 2026
65 checks passed
@tlambert03 tlambert03 deleted the misc-bugs branch March 8, 2026 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant