feat: unify image stats and use ihist#249
Merged
tlambert03 merged 11 commits intopyapp-kit:mainfrom Mar 8, 2026
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #249 +/- ##
==========================================
+ Coverage 86.85% 86.96% +0.11%
==========================================
Files 46 47 +1
Lines 5347 5441 +94
==========================================
+ Hits 4644 4732 +88
- Misses 703 709 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…nificant bits handling in image stats computation
…e image stats computation
…ew histogram test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this consolidates two image statistics paths that used to be serial and independent (calculation of clims and the conditional calculation of histograms) into a single
compute_image_stats, backed by ihist (thanks @marktsuchida !)ihist→ minmax from countsihist→ percentile from CDFihist(bits=12)→ minmax from countsnanmin/max→np.histogram(256)ihist→ percentile from CDFnanmin/nanmax(unchanged)nanmean/nanstd(unchanged)