Image casting, downsampling, and pygfx texture reuse#60
Merged
gselzer merged 16 commits intopyapp-kit:mainfrom Apr 9, 2026
Merged
Image casting, downsampling, and pygfx texture reuse#60gselzer merged 16 commits intopyapp-kit:mainfrom
gselzer merged 16 commits intopyapp-kit:mainfrom
Conversation
The dimensions were inverted, and I just had no tests that were checking for situations where image width was not equal to image height
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #60 +/- ##
==========================================
+ Coverage 88.13% 88.33% +0.19%
==========================================
Files 62 62
Lines 2950 3060 +110
==========================================
+ Hits 2600 2703 +103
- Misses 350 357 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves image/volume handling for GPU backends (primarily pygfx, with parallel updates for vispy) by coercing texture inputs to backend-compatible shapes/dtypes, downsampling oversized textures, and reusing textures where possible.
Changes:
- Add dtype downcasting and max-texture-size downsampling paths for vispy and pygfx adaptors.
- Add pygfx texture reuse on same-shape/dtype updates (and recreate on incompatible changes).
- Update model bounding box/transform expectations and expand tests to cover new behavior.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
src/scenex/model/_nodes/image.py |
Updates bounding box computation to align with (Y, X) image axis conventions. |
src/scenex/model/_nodes/volume.py |
Removes custom bounding box override and adjusts volume ray intersection shape unpacking. |
src/scenex/adaptors/_vispy/_image.py |
Introduces _coerce_data (downcast/downsample) and transform compensation for downsampled uploads. |
src/scenex/adaptors/_vispy/_volume.py |
Uses _coerce_data for volume uploads and adds transform compensation factors. |
src/scenex/adaptors/_pygfx/_image.py |
Adds _coerce_data, downsampling, and texture reuse logic for images. |
src/scenex/adaptors/_pygfx/_volume.py |
Adds _coerce_data, downsampling, and texture reuse logic for volumes. |
tests/model/_nodes/test_image.py |
Updates image bounding box test for non-square (Y, X) data. |
tests/model/_nodes/test_volume.py |
Updates volume bounding box test for non-square (Z, Y, X) data. |
tests/adaptors/_vispy/test_image.py |
Adds tests for oversize downsampling and dtype downcasting. |
tests/adaptors/_vispy/test_volume.py |
Adds tests for oversize downsampling and dtype downcasting. |
tests/adaptors/_pygfx/test_image.py |
Adds tests for oversize downsampling and texture reuse/recreation behavior. |
tests/adaptors/_pygfx/test_volume.py |
Adds tests for oversize downsampling and texture reuse/recreation behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Allows for better handling of RGB images
And don't do it in the vispy node ctor :)
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
gselzer
changed the title
This should better match user intent. If you have negative data, you probably don't want it clamped to zero or wrapped around. You probably still want it to show up as the same/lighter than zero on the canvas.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a couple features targeted at improving the pygfx backend.