Skip to content

Reuse value format logic for label width determination in sliders#346

Merged
tlambert03 merged 1 commit into
pyapp-kit:mainfrom
brisvag:fix/slider-labels
May 15, 2026
Merged

Reuse value format logic for label width determination in sliders#346
tlambert03 merged 1 commit into
pyapp-kit:mainfrom
brisvag:fix/slider-labels

Conversation

@brisvag
Copy link
Copy Markdown
Contributor

@brisvag brisvag commented May 13, 2026

There is still a small overlap between the handle label text if they are both long. Not sure why that's the case. At least it solves the "cropping" problem from the original issue.

Before:
image

After:

image

@codecov
Copy link
Copy Markdown

codecov Bot commented May 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.96%. Comparing base (595b284) to head (dd91e78).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #346      +/-   ##
==========================================
+ Coverage   84.85%   84.96%   +0.11%     
==========================================
  Files          49       49              
  Lines        3909     3912       +3     
==========================================
+ Hits         3317     3324       +7     
+ Misses        592      588       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tlambert03
Copy link
Copy Markdown
Member

thanks @brisvag

@tlambert03 tlambert03 merged commit a32a3a4 into pyapp-kit:main May 15, 2026
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

QLabeledDoubleRangeSlider label width too small

3 participants