Skip to content

Conversation

@rtimms
Copy link
Contributor

@rtimms rtimms commented Nov 17, 2025

Description

Fixes a bug where "lithiation" wasn't passed to the bulk OCP ( U_lith_bulk = self.phase_param.U(sto_bulk, T_bulk, "lithiation")) which led to incorrect outputs for the "particle concentration overpotential" variables.

Fixes # (issue)

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #)

Important checks:

Please confirm the following before marking the PR as ready for review:

  • No style issues: nox -s pre-commit
  • All tests pass: nox -s tests
  • The documentation builds: nox -s doctests
  • Code is commented for hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@rtimms rtimms requested a review from a team as a code owner November 17, 2025 13:24
@codecov
Copy link

codecov bot commented Nov 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.77%. Comparing base (6ba2cde) to head (2c36b3d).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #5280   +/-   ##
========================================
  Coverage    98.77%   98.77%           
========================================
  Files          321      321           
  Lines        27727    27727           
========================================
  Hits         27387    27387           
  Misses         340      340           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rtimms rtimms merged commit e893156 into develop Nov 18, 2025
21 of 22 checks passed
@rtimms rtimms deleted the hysteresis-bulk-ocp-bug branch November 18, 2025 07:30
BradyPlanden pushed a commit that referenced this pull request Nov 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants