Replace setup.py with pyproject.toml #281
Conversation
* Replace setup.py with pyproject.toml pyproject.toml is the modern way of listing package metadata. Since this library is not doing anything complex in the build process the setup.py is no longer needed. * Fix find packages
|
Note that I change the licence string from |
|
I also need to update the url |
Co-authored-by: Axel Huebl <axel.huebl@plasma.ninja>
pyproject.toml
Outdated
| name = "pybind11-stubgen" | ||
| description = "PEP 561 type stubs generator for pybind11 modules" | ||
| version = "2.5.5" | ||
| requires-python = "~=3.10" |
There was a problem hiding this comment.
I think >= is recommended:
| requires-python = "~=3.10" | |
| requires-python = ">=3.10" |
There was a problem hiding this comment.
Ah, I am sorry. I do not want you to have to update all CI tests with Python 3.8 and 3.9 here.
Let's do
| requires-python = "~=3.10" | |
| requires-python = ">=3.8" |
There was a problem hiding this comment.
"~=3.10" allows any 3.x release greater or equal to 3.10. Python 4 could break some code in a way we can't anticipate.
There was a problem hiding this comment.
Yeah, but there were some blog posts on not limiting upper versions like this, I think @henryiii has a good writeup
|
The old builds will fail now because we have disabled support for them. I have another pull which rewrites the tests. Perhaps we should merge that first. |
|
Let's keep the version here with |
2 participants
pyproject.toml is the modern way of listing package metadata.
Since this library is not doing anything complex in the build process the setup.py is no longer needed.