Open
Conversation
Ready the repo up for pre-commit.ci Replaced the old local black / isort / flake8 hooks with official Ruff hooks in `.pre-commit-config.yaml`, and added a `ci:` block with quarterly autoupdates to keep bot churn down. Also added `pre-commit` to the `[dev]` dependency group in `pyproject.toml`, updated `uv.lock`, and added local setup instructions in `README.md`. While verifying, pre-commit fixed one existing whitespace issue in `tests/py-demo/bindings/src/modules/methods.cpp:10`. Validation passed with `uv run pre-commit validate-config` and `uv run pre-commit run --all-files`
between pre-commit and GH action
skarndev
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ready the repo up for pre-commit.ci
Replaced the old local black / isort / flake8 hooks with official Ruff hooks in
.pre-commit-config.yaml, and added aci:block with quarterly autoupdates to keep bot churn down.Also added
pre-committo the[dev]dependency group inpyproject.toml(* see below), updateduv.lock, and added local setup instructions inREADME.md.While verifying, pre-commit fixed one existing whitespace issue in
tests/py-demo/bindings/src/modules/methods.cpp:10. Validation passed withuv run pre-commit validate-configanduv run pre-commit run --all-filesClean-Up
We will want to make sure we to use the exact same
ruffversion everywhere. So test scripts should not useruffdirectly and we only maintain version once in.pre-commit-config.yaml, not also inpyproject.toml.