Skip to content

chore: Minor opt/code cleanliness to cache tuple casting #3894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 24, 2022
Merged

chore: Minor opt/code cleanliness to cache tuple casting #3894

merged 1 commit into from
Apr 24, 2022

Conversation

@Skylion007
Copy link
Collaborator

@Skylion007 Skylion007 commented Apr 24, 2022

Description

  • Was looking through the code, caught a minor double cast of a tuple. Let's cache the var and make it easier on the compiler.

@Skylion007 Skylion007 requested review from henryiii and rwgk April 24, 2022 15:57
@Skylion007 Skylion007 merged commit 82455a4 into pybind:master Apr 24, 2022
@Skylion007 Skylion007 deleted the skylion007/numpy-cache-double-tuple-cast branch April 24, 2022 18:46
@github-actions github-actions bot added the needs changelog Possibly needs a changelog entry label Apr 24, 2022
@henryiii henryiii removed the needs changelog Possibly needs a changelog entry label Jul 5, 2022
@rwgk rwgk mentioned this pull request Feb 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@henryiii henryiii henryiii approved these changes

@rwgk rwgk Awaiting requested review from rwgk

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Skylion007 @henryiii