Skip to content

chore: add a missing std::move in numpy.h #4005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 14, 2022
Merged

chore: add a missing std::move in numpy.h #4005

merged 1 commit into from
Jun 14, 2022

Conversation

@Skylion007
Copy link
Collaborator

@Skylion007 Skylion007 commented Jun 14, 2022

Description

  • Add a missing std::move to prevent one extra string copy in numpy.h that I noticed.

@Skylion007 Skylion007 requested review from henryiii and rwgk June 14, 2022 16:36
@Skylion007 Skylion007 merged commit 0964a90 into pybind:master Jun 14, 2022
@Skylion007 Skylion007 deleted the skylion007/numpy-format-str-move branch June 14, 2022 18:20
@github-actions github-actions bot added the needs changelog Possibly needs a changelog entry label Jun 14, 2022
@Skylion007 Skylion007 removed the needs changelog Possibly needs a changelog entry label Jun 14, 2022
@rwgk rwgk mentioned this pull request Feb 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rwgk rwgk rwgk approved these changes

@henryiii henryiii Awaiting requested review from henryiii

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Skylion007 @rwgk