Scratch PR: clone of #4293 that could be merged immediately without disrupting anything #4307
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… other disruption.
|
Note: Please ignore the CI results that are currently showing: that was a failed attempt to make "Upstream" test with Python 3.12. Unfortunately 3.12.0a1 isn't available yet at https://raw.githubusercontent.com/actions/python-versions/main/versions-manifest.json When I saw the Upstream failure I canceled the CI workflow, to not waste CPU cycles. The previous CI run, without Upstream, was successful. |
rwgk
added a commit
to rwgk/pybind11
that referenced
this pull request
Nov 17, 2022
Modifications are: * Backward compatibility (no ABI break), as originally under PR pybind#4307. * Naming: `get_python_state_dict()`, `has_pybind11_internals_capsule()` * Report error retrieving `internals**` from capsule instead of clearing it. Locally tested with ASAN, MSAN, TSAN, UBSAN (Google-internal toolchain).
|
Closing this PR because:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Scratch PR for testing.
Rebased on current master.
Suggested changelog entry: