Accept any sequence type as std::vector (or std::list) #445
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current implementation of the STL container casters functions which take
std::vector
orstd::list
arguments in C++ will only acceptlist
in Python. This is not very Pythonic. Users will expect the functions to be callable with any other sequence type (e.g.tuple
).This PR implements that capability. It only affects
std::vector
andstd::list
to not complicate overloading onstd::tuple
orstd::pair
arguments, but could potentially be extended to cover those as well.Note that this only affects
load
, functions returningstd::vector
orstd::list
will still return a Pythonlist
.