Skip to content

Conversation

@Skylion007
Copy link
Collaborator

@Skylion007 Skylion007 commented Mar 27, 2023

Description

Updates #4587 to use more consistent cpp feature macro to determine if the fold expression feature is available. This will also allow the feature to be used on older compilers that support it, but may not have full CPP17 codebase or allow the fold expression feature to be enabled if desired.

@Skylion007 Skylion007 changed the title chore: make #4587 use proper cpp17 feature macro chore: make #4587 use fold expr cpp17 feature macro Mar 27, 2023
@Skylion007 Skylion007 marked this pull request as ready for review March 27, 2023 14:29
@Skylion007 Skylion007 requested review from henryiii and rwgk March 27, 2023 14:29
Copy link
Collaborator

@rwgk rwgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Aaron!

@Skylion007 Skylion007 merged commit 66f12df into pybind:master Mar 27, 2023
@github-actions github-actions bot added the needs changelog Possibly needs a changelog entry label Mar 27, 2023
@Skylion007 Skylion007 deleted the skylion007/concat-cpp-fold-ver-macro branch March 27, 2023 15:52
@rwgk rwgk removed the needs changelog Possibly needs a changelog entry label May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants