Skip to content

Conversation

@henryiii
Copy link
Collaborator

@henryiii henryiii commented Apr 5, 2025

Also modernizing slightly. We should probably get off of ubuntu-20.04 as it's probably not going to be a runner for much longer.

@rwgk
Copy link
Collaborator

rwgk commented Apr 9, 2025

Looks good to me. Do you still want to get rid of the job with -DPYBIND11_INTERNALS_VERSION=10000000? Currently it's pretty much useless, as you suspected. I think you can simply delete this block:

  • # Third build - C++17 mode with unstable ABI
    - name: Configure (unstable ABI)
    run: >
    cmake -S . -B build3
    -DPYBIND11_WERROR=ON
    -DPYBIND11_PYTEST_ARGS=-v
    -DDOWNLOAD_CATCH=ON
    -DDOWNLOAD_EIGEN=ON
    -DCMAKE_CXX_STANDARD=17
    -DPYBIND11_INTERNALS_VERSION=10000000
    ${{ matrix.args }}
    - name: Build (unstable ABI)
    run: cmake --build build3 -j 2
    - name: Python tests (unstable ABI)
    run: cmake --build build3 --target pytest

@henryiii henryiii force-pushed the henryiii/ci/speedup1 branch from b7441df to 18c726c Compare April 10, 2025 21:34
henryiii and others added 7 commits April 10, 2025 18:31
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
@henryiii henryiii force-pushed the henryiii/ci/speedup1 branch from 85997ff to c01c66b Compare April 10, 2025 22:31
@henryiii henryiii merged commit 662a88c into pybind:master Apr 11, 2025
65 checks passed
@henryiii henryiii deleted the henryiii/ci/speedup1 branch April 11, 2025 03:21
@github-actions github-actions bot added the needs changelog Possibly needs a changelog entry label Apr 11, 2025
@henryiii henryiii removed the needs changelog Possibly needs a changelog entry label May 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants