Skip to content

Adding cmake functions to generate docs#51

Merged
henryiii merged 27 commits intopybind:masterfrom
leakec:cmake
Apr 11, 2026
Merged

Adding cmake functions to generate docs#51
henryiii merged 27 commits intopybind:masterfrom
leakec:cmake

Conversation

@leakec
Copy link
Copy Markdown
Contributor

@leakec leakec commented Feb 22, 2026

Implementing #23.

  • Added a function as described in the issue with the addition of EXTRA_ARGS.
  • Added cmake config and version so one can do find_package(pybind11_mkdoc)
  • Added get_cmake_dir function to easily get the CMake directory.
  • Added unit tests.
  • Added docs to the README.md.

leakec added 15 commits February 22, 2026 07:18
@leakec
Adding cmake function. See pybind#23
0aa3cae
@leakec
Adding files to create config and versions.
1019bb5
@leakec
Adding build artifacts to .gitignore.
9e2fd54
@leakec
Adding makefile to make it easy to re-generate when necessary.
a66967e
@leakec
Adding these files to version control, since users will often install…
e1e6dd2 
… directly from GitHub.
@leakec
Moving things around to make installing easier.
d82c114
@leakec
Adding method to get the cmake directory.
5702898
@leakec
Some minor tweaks to get this working in more cases.
baf6322
@leakec
Adding simple unit test to ensure cmake is working.
3d83ce0
@leakec
Adding test for EXTRA_ARGS as well.
25a4d66
@leakec
Ran ruff and fixed errors.
9e1ae61
@leakec
Fixing name.
a918886
@leakec
Adding docs.
c458953
@leakec
Trying to sync test group first to ensure dependencies are installed.
b09b362
@leakec
Trying again, but just adding pybind11 to --with.
c96a17c
@leakec
Copy link
Copy Markdown
Contributor Author

leakec commented Feb 22, 2026 •
edited
Loading

Tagging @henryiii for a review.

EDIT: No longer need help with what is below, I got this all sorted.
and some help with the CI. I have not used uv run at all (I've only used it for venv and installing packages). I'd like to ensure pybind11 is installed in the environment the tests are running in, as cmake will be searching for it. However, even though it is in the test group it does not seem to install automatically. I also added it to the --with statement, but that didn't seem to do it either.

@leakec
Copy link
Copy Markdown
Contributor Author

leakec commented Mar 10, 2026

@henryiii Just pinging this again as a gentle reminder

@leakec
Copy link
Copy Markdown
Contributor Author

leakec commented Mar 31, 2026

@henryiii Just pinging this again as a gentle reminder

@henryiii
Copy link
Copy Markdown
Collaborator

henryiii commented Apr 9, 2026

Oh, sorry, missed it. A little too gentle. :)

henryiii
henryiii reviewed Apr 9, 2026
View reviewed changes
leakec and others added 6 commits April 9, 2026 14:56
@leakec @henryiii
Update cmake/CMakeLists.txt
1c39ee5 
Co-authored-by: Henry Schreiner <HenrySchreinerIII@gmail.com>
@leakec
Resolving some MR comments.
5a9c4d8
@leakec
Removing this unecessary line (as of pybind11 3.0).
268248e
@henryiii
chore: add a presets file
58a885a 
Signed-off-by: Henry Schreiner <henryfs@princeton.edu>
@henryiii
fix: install target
6a65608 
Signed-off-by: Henry Schreiner <henryfs@princeton.edu>
@leakec
Removed Makefile, added README.md, and updated pybind11_mkdoc_functions.
bac011c
henryiii
henryiii reviewed Apr 10, 2026
View reviewed changes
henryiii
henryiii reviewed Apr 10, 2026
View reviewed changes
leakec and others added 3 commits April 10, 2026 12:08
@leakec @henryiii
Update cmake/CMakePresets.json
fe5a0e3 
Co-authored-by: Henry Schreiner <HenrySchreinerIII@gmail.com>
@leakec @henryiii
Update cmake/CMakePresets.json
4a66658 
Co-authored-by: Henry Schreiner <HenrySchreinerIII@gmail.com>
@leakec
Added back in default-install.
e9fd2d6
@henryiii henryiii merged commit 3d391a5 into pybind:master Apr 11, 2026
8 checks passed
@leakec leakec mentioned this pull request Apr 11, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@henryiii henryiii henryiii left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@leakec @henryiii