PCC01 NNRepos #845
PCC01 NNRepos #845
Conversation
| if dictionary is None: | ||
| dictionary = load_words() | ||
| print("crap:", [x for x in dictionary if "-" in x]) | ||
| return list(sorted(([calc_word_value(word), word] for word in dictionary), reverse=True))[0][1] |
There was a problem hiding this comment.
sorted() already returns a list. I would break this out into multiple lines, which would make it more readable.
There was a problem hiding this comment.
Consider using the max() built-in here, for example: https://github.com/pybites/challenges/blob/solutions/01/wordvalue.py
There was a problem hiding this comment.
i was actually looking for something like this: key=calc_word_value. that's very nice
| def calc_word_value(word: str) -> int: | ||
| """Calculate the value of the word entered into function | ||
| using imported constant mapping LETTER_SCORES""" | ||
| return sum(LETTER_SCORES[letter] for letter in list(word.replace('-', '').upper())) |
There was a problem hiding this comment.
I don't think you need the list(), word is already iterable. The solution also uses LETTER_SCORES.get(char.upper(), 0) which is safer, because with LETTER_SCORES[letter] any unexpected letter would raise a KeyError.
There was a problem hiding this comment.
i actually used the KeyError for debugging (that's how i've discovered that - is a legal character), but for correctness, i guess you're right.
2 participants
Difficulty level (1-10): [1]
Estimated time spent (hours): [0.5]
Completed (yes/no): [yes]
I stretched my coding skills (if yes what did you learn?): [no]
Other feedback (what can we improve?): [probably makes more sense to use relative imports,
that way we don't have to copy and delete the files to run the tests.]