PCC02 NNRepos #847
Merged
PCC02 NNRepos #847
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ignored internal implementation tests improved PCC01
bbelderbos
reviewed
Oct 10, 2022
|
|
||
| def is_legal_word(word: str, drawn_letters_count: Dict[str, int]) -> bool: | ||
| word_letters_count = Counter(word.upper()) | ||
| for letter, count in word_letters_count.items(): |
Collaborator
There was a problem hiding this comment.
Could also use any/ all built-ins
Contributor
Author
There was a problem hiding this comment.
that's right, didn't think about it :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
notes:
Difficulty level (1-10): [2]
Estimated time spent (hours): [1]
Completed (yes/no): [yes]
I stretched my coding skills (if yes what did you learn?): [no]
Other feedback (what can we improve?): [i don't think tests should be testing internal implementation. a good test only tests behaviour. that's why i did not create some of the required implementation methods (e.g.
_validate).]