Pcc02 #848
Merged
Pcc02 #848
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbelderbos
approved these changes
Oct 24, 2022
| def get_possible_dict_words(draw): | ||
| """Get all possible words from draw which are valid dictionary words. | ||
| Use the _get_permutations_draw helper and DICTIONARY constant""" | ||
| all_options = [] |
Collaborator
There was a problem hiding this comment.
redundant / gets overwritten in next statement
| [int(letter.value) for letter in distribution] | ||
| )) | ||
|
|
||
| assert LETTER_SCORES['A'] == 1 |
Collaborator
There was a problem hiding this comment.
would these asserts be better placed in a the tests?
| all_options = _get_permutations_draw(draw) | ||
|
|
||
| dictionary_words = [] | ||
| for word in all_options: |
Collaborator
There was a problem hiding this comment.
could use a listcomp:
[word for word in all_options if word.lower() in DICTIONARY]
| else: | ||
| raise ValueError("You need to use the letters shown") | ||
|
|
||
| if word.lower() not in DICTIONARY: |
Collaborator
There was a problem hiding this comment.
could possibly drop this check, because get_possible_dict_words() already filters dictionary only words, however that does mean that it always need to be called before this function = coupling, so could leave in as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ATTENTION: before clicking "Create Pull Request" please submit some meta data, thanks!
Difficulty level (1-10): [8]
Estimated time spent (hours): [2.5]
Completed (yes/no): [yes]
I stretched my coding skills (if yes what did you learn?): [itertools]
Other feedback (what can we improve?): []