Pcc03 #849
Merged
Pcc03 #849
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbelderbos
approved these changes
Oct 26, 2022
|
|
||
| ### Can I help you out with code reviewing? | ||
| We are still getting a pretty manageable number of PRs to be able to merge them all in ourselves, but we do want to give each PR a bit more of a code review. As we're pretty busy we want to turn this into a *community effort*. So if you want to help out merging PRs into our challenges branch, become a moderator (and mentor!), you can volunteer [on Slack](https://join.slack.com/t/pybites/shared_invite/enQtNDAxODc0MjEyODM2LTNiZjljNTI2NGJiNWI0MTRkNjY4YzQ1ZWU4MmQzNWQyN2Q4ZTQzMTk0NzkyZTRmMThlNmQzYTk5Y2Y5ZDM4NDU). | ||
| We are still getting a pretty manageable number of PRs to be able to merge them all in ourselves, but we do want to give each PR a bit more of a code review. As we're pretty busy we want to turn this into a *community effort*. So if you want to help out merging PRs into our challenges branch, become a moderator (and mentor!), you can volunteer [on Slack](https://pybit.es/community/). |
| Hint 2: use SequenceMatcher (imported) to calculate the similarity ratio | ||
| Bonus: for performance gain compare the first char of each tag in pair and continue if not the same""" | ||
| result = {} | ||
| result = {} |
| with open("rss.xml", "r") as f: | ||
| for line in f: | ||
| line = line.replace("-", " ").lower() | ||
| tags = TAG_HTML.findall(line) |
Collaborator
There was a problem hiding this comment.
will this override tags in each loop?
you can do it once, no loop: TAG_HTML.findall(f.read().lower())
| singular = x | ||
| if x[0] == y[0] and x != y: | ||
| ratio = SequenceMatcher(None, x, y).ratio() | ||
| if x.endswith("s"): |
Collaborator
There was a problem hiding this comment.
not sure if this was required?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ATTENTION: before clicking "Create Pull Request" please submit some meta data, thanks!
Difficulty level (1-10): [5]
Estimated time spent (hours): [3]
Completed (yes/no): [yes]
I stretched my coding skills (if yes what did you learn?): []
Other feedback (what can we improve?): []