Skip to content

ble-pybricks-service/sagas: simplify test#2321

Merged
dlech merged 1 commit intomasterfrom
fix-test
Oct 27, 2024
Merged

ble-pybricks-service/sagas: simplify test#2321
dlech merged 1 commit intomasterfrom
fix-test

Conversation

@dlech
Copy link
Member

@dlech dlech commented Oct 27, 2024

I meant to change this before merging the previous commit, but missed it.

The mismatch test was hard to understand and didn't increase coverage, so let's leave it out.

I meant to change this before merging the previous commit, but missed it.

The mismatch test was hard to understand and didn't increase coverage,
so let's leave it out.
@dlech dlech enabled auto-merge (rebase) October 27, 2024 23:08
@codecov
Copy link

codecov bot commented Oct 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.61%. Comparing base (baaa9a7) to head (75e55b8).
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2321      +/-   ##
==========================================
+ Coverage   72.47%   72.61%   +0.13%     
==========================================
  Files         201      201              
  Lines        5127     5163      +36     
  Branches     1086     1094       +8     
==========================================
+ Hits         3716     3749      +33     
- Misses       1374     1377       +3     
  Partials       37       37              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dlech dlech merged commit 0472978 into master Oct 27, 2024
@dlech dlech deleted the fix-test branch October 27, 2024 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant