bricks: Restore PYBRICKS_PY_HUBS for technichub #425
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The flag was removed in 1ccc277.
Member
|
Thanks! |
Member
|
Thanks @Debenben!
Oops! Yep, there is no conspiracy to remove Technic Hub support from Technic Hub 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
from pybricks.hubs import TechnicHubdoes not work with the nightly build. I guess the flag to add pybricks.hubs to technichub was removed by accident in 1ccc277 since the commit message does not mention it and I have not seen any issues when including it. Otherwise feel free to decline this.