Skip to content

cli.flash: finish removal of REPLHub #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 7, 2025
Merged

cli.flash: finish removal of REPLHub #118

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 1 addition & 40 deletions pybricksdev/cli/flash.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,10 @@
# Copyright (c) 2019-2023 The Pybricks Authors

import asyncio
import hashlib
import json
import logging
import os
import struct
import sys
import zipfile
import zlib
from tempfile import NamedTemporaryFile
from typing import BinaryIO, Dict, Optional
Expand Down Expand Up @@ -46,7 +43,6 @@
unpack_pnp_id,
)
from pybricksdev.compile import compile_file
from pybricksdev.connections.lego import REPLHub
from pybricksdev.dfu import flash_dfu
from pybricksdev.firmware import create_firmware_blob
from pybricksdev.flash import BootloaderConnection
Expand Down Expand Up @@ -439,42 +435,7 @@ async def flash_firmware(firmware_zip: BinaryIO, new_name: Optional[str]) -> Non
hub_kind = HubKind(metadata["device-id"])

if hub_kind in (HubKind.TECHNIC_SMALL, HubKind.TECHNIC_LARGE):
try:
# Connect to the hub and exit the runtime.
hub = REPLHub()
await hub.connect()
await hub.reset_hub()

# Upload installation script.
archive = zipfile.ZipFile(firmware_zip)
await hub.exec_line("import uos; uos.mkdir('_firmware')")
await hub.upload_file(
"_firmware/install_pybricks.py",
bytearray(archive.open("install_pybricks.py").read()),
)

extended_metadata = metadata.copy()

# Add extended metadata needed by install_pybricks.py
extended_metadata["firmware-sha256"] = hashlib.sha256(firmware).hexdigest()

# Upload metadata.
await hub.upload_file(
"_firmware/firmware.metadata.json",
json.dumps(extended_metadata, indent=4).encode(),
)

# Upload Pybricks firmware
await hub.upload_file("_firmware/firmware.bin", firmware)

# Run installation script
print("Installing firmware")
await hub.exec_line("from _firmware.install_pybricks import install")
await hub.exec_paste_mode("install()")

except OSError:
print("Could not find hub in standard firmware mode. Trying DFU.")
flash_dfu(firmware, metadata)
flash_dfu(firmware, metadata)
elif hub_kind in [HubKind.BOOST, HubKind.CITY, HubKind.TECHNIC]:
await flash_ble(hub_kind, firmware, metadata)
elif hub_kind == HubKind.NXT:
Expand Down