add support custom comments when formatting openssh private keys

[gzm55]

The comment field is left empty when formatting as openssh key protocol. can we support to custom this comment field?

[alex]

I think we'd accept a PR that added support to https://cryptography.io/en/latest/hazmat/primitives/asymmetric/serialization/#cryptography.hazmat.primitives.serialization.KeySerializationEncryptionBuilder

[gzm55]

when parsing from bytes, the comment is also lost.

[alex]

I think we'd also be happy to take a PR exposing it.

…

On Fri, Jun 2, 2023 at 1:26 PM James Z.M. Gao ***@***.***> wrote: when parsing from bytes, the comment is also lost. — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you commented.Message ID: ***@***.***>

-- All that is necessary for evil to succeed is for good people to do nothing.

[gzm55]

I think we'd also be happy to take a PR exposing it.
…
On Fri, Jun 2, 2023 at 1:26 PM James Z.M. Gao @.> wrote: when parsing from bytes, the comment is also lost. — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you commented.Message ID: @.>
-- All that is necessary for evil to succeed is for good people to do nothing.

@alex here is a simple pr to fix this issue

[gzm55]

any comments about this issue or the pr?

[gzm55]

I think we'd also be happy to take a PR exposing it.
…
On Fri, Jun 2, 2023 at 1:26 PM James Z.M. Gao @.> wrote: when parsing from bytes, the comment is also lost. — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you commented.Message ID: _@**.**_>
-- All that is necessary for evil to succeed is for good people to do nothing.

@alex here is a simple pr to fix this issue

@alex any other way to fix this issue?

[reaperhulk]

We've had no activity here in over a year. The approach needs to be rethought, but we're willing to take a PR for comment parsing still.