bump MSRV to 1.74 #12919
Merged
bump MSRV to 1.74 #12919
+18
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex
previously approved these changes
May 17, 2025
alex
previously approved these changes
May 17, 2025
alex
approved these changes
May 17, 2025
|
Curious that you did this just before the release - no criticism implied, just that the whole development cycle was done with the old MSRV, so it would seem to have cost ~nothing to release with that and bump afterwards. |
Member
Author
|
That's not a bad point -- we could have done it in any order and I simply didn't think about it to be honest. We did also check the download data on pypi and saw we had ~98% on 1.74+. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.